kennknowles commented on a change in pull request #14072:
URL: https://github.com/apache/beam/pull/14072#discussion_r583289942



##########
File path: 
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -915,6 +915,21 @@ private Debuggee registerDebuggee(CloudDebugger 
debuggerClient, String uniquifie
 
   @Override
   public DataflowPipelineJob run(Pipeline pipeline) {
+
+    if (useUnifiedWorker(options)) {

Review comment:
       Nevermind, I was looking at stale results. It succeeds. Since the 
failures were in branches for `!useUnifiedWorker` this should not even execute. 
So the failure really had _something_ to do with it being a `Set` or how the 
variable was carried through the codepaths. Setting it back right away like you 
suggested would probably also have fixed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to