kennknowles commented on a change in pull request #14059:
URL: https://github.com/apache/beam/pull/14059#discussion_r583300306
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java
##########
@@ -332,7 +332,7 @@
public WindowingStrategy<?, ?>
getOutputStrategyInternal(WindowingStrategy<?, ?> inputStrategy) {
WindowingStrategy<?, ?> result = inputStrategy;
if (getWindowFn() != null) {
- result = result.withWindowFn(getWindowFn());
+ result = result.withAlreadyMerged(false).withWindowFn(getWindowFn());
Review comment:
This is a "model" question, sort of:
- if the user calls `Window.into(WindoFn)` we definitely reset
`alreadyMerged`.
- if the user calls `Window.remerge()` we reset `alreadyMerged`.
- if the user calls `Window.configure()` to set a new trigger, accumulation
mode, or allowed lateness: should we reset `alreadyMerged`? I decided that we
should not. So if windowFn is null, we do not reset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
