y1chi commented on a change in pull request #14095:
URL: https://github.com/apache/beam/pull/14095#discussion_r583878382
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##########
@@ -2002,6 +2019,26 @@ def test_gbk_many_values(self):
assert_that(r, equal_to([VALUES_PER_ELEMENT * NUM_OF_ELEMENTS]))
+# TODO(robertwb): Why does pickling break when this is inlined?
+class CustomMergingWindowFn(window.WindowFn):
+ def assign(self, assign_context):
+ return [
+ window.IntervalWindow(
+ assign_context.timestamp, assign_context.timestamp + 1)
Review comment:
Could we increase `assign_context.timestamp + 1` to `maybe
assign_context.timestamp + 100`? It seems that for dataflow runner v2, in batch
the windows are inserted and fired in order, window like [2, 3) could already
been fired when element with timestamp 100 arrives, and the merging behavior
may be inconsistent with direct runner or ULR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
