sonam-vend commented on a change in pull request #14035:
URL: https://github.com/apache/beam/pull/14035#discussion_r585470992
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -91,6 +92,12 @@
x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
new UdafImpl<>(new ArrayAgg.ArrayAggArray()));
+ public static final SqlOperator ARRAY_CONCAT_AGG_FN =
+ createUdafOperator(
+ "array_concat_agg",
+ x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
Review comment:
@ibzib changing` ARRAY<ARRAY<BIGINT>>` to` ARRAY<BIGINT>` from works,
thanks for your help
```
x -> createTypeFactory()
.createArrayType(createTypeFactory().createSqlType(SqlTypeName.BIGINT), -1),
```
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -91,6 +92,12 @@
x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
new UdafImpl<>(new ArrayAgg.ArrayAggArray()));
+ public static final SqlOperator ARRAY_CONCAT_AGG_FN =
+ createUdafOperator(
+ "array_concat_agg",
+ x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
Review comment:
@ibzib changing from ` ARRAY<ARRAY<BIGINT>>` to` ARRAY<BIGINT>` works,
thanks for your help
```
x -> createTypeFactory()
.createArrayType(createTypeFactory().createSqlType(SqlTypeName.BIGINT), -1),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
