robertwb commented on a change in pull request #14060: URL: https://github.com/apache/beam/pull/14060#discussion_r586020750
########## File path: sdks/python/apache_beam/transforms/trigger.py ########## @@ -369,6 +370,53 @@ def has_ontime_pane(self): return False +class AfterSynchronizedProcessingTime(TriggerFn): Review comment: Given you're already doing a local import, I would be fine with importing it directly from here rather than putting it in `__all__`. (That and we could add a leading underscore.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org