ibzib commented on a change in pull request #14114:
URL: https://github.com/apache/beam/pull/14114#discussion_r587701556
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -177,7 +177,11 @@ class BeamModulePlugin implements Plugin<Project> {
* By default, skips anything in the `org.apache.beam.model` namespace.
*/
List<String> generatedClassPatterns = [
- "^org\\.apache\\.beam\\.model.*"
+ "^org\\.apache\\.beam\\.model\\.pipeline\\.v1\\.*",
Review comment:
Doesn't `^org\\.apache\\.beam\\.model.*` cover all of the these except
the windmill worker?
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -51,6 +51,7 @@ class GrpcVendoring_1_26_0 {
"com.google.protobuf:protobuf-java:$protobuf_version",
"com.google.protobuf:protobuf-java-util:$protobuf_version",
"com.google.code.gson:gson:$gson_version",
+ "io.grpc:grpc-api:h$grpc_version",
Review comment:
Is this a typo?
```suggestion
"io.grpc:grpc-api:$grpc_version",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
