tvalentyn commented on a change in pull request #14145:
URL: https://github.com/apache/beam/pull/14145#discussion_r587876964
##########
File path:
.test-infra/jenkins/job_PostCommit_Python_ValidatesContainer_Dataflow.groovy
##########
@@ -35,11 +35,13 @@
PostcommitJobBuilder.postCommitJob('beam_PostCommit_Py_ValCont',
}
// Execute shell command to test Python SDK.
- // TODO: Parallel the script run with Jenkins DSL or Gradle.
steps {
- VALIDATES_CONTAINER_DATAFLOW_PYTHON_VERSIONS.each {
- pythonVersion = it.replace('.', '')
- shell('cd ' + commonJobProperties.checkoutDir + " && bash
sdks/python/container/run_validatescontainer.sh python${pythonVersion}")
+ gradle {
+ rootBuildScriptDir(commonJobProperties.checkoutDir)
+ tasks(':sdks:python:test-suites:portable:py36:validatesContainer')
Review comment:
I suggest we add a constant along these lines
https://github.com/apache/beam/blob/2b8938eced3b5776441246f521a38af5269f916a/sdks/python/test-suites/gradle.properties#L28
and a top-level task like so:
https://github.com/apache/beam/blob/9f9dcd6e97b29c020f555bcaa992af56108aaa0d/sdks/python/test-suites/dataflow/build.gradle#L58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
