ibzib commented on a change in pull request #14148:
URL: https://github.com/apache/beam/pull/14148#discussion_r588512484
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1027,14 +1028,14 @@ class BeamModulePlugin implements Plugin<Project> {
project.apply plugin: 'net.ltgt.errorprone'
project.dependencies {
- errorprone("com.google.errorprone:error_prone_core:2.3.1")
+
errorprone("com.google.errorprone:error_prone_core:$errorprone_version")
errorprone("jp.skypencil.errorprone.slf4j:errorprone-slf4j:0.1.2")
// At least JDk 9 compiler is required, however JDK 8 still can be
used but with additional errorproneJavac
// configuration. For more details please see
https://github.com/tbroyer/gradle-errorprone-plugin#jdk-8-support
errorproneJavac("com.google.errorprone:javac:9+181-r4173-1")
}
- project.configurations.errorprone { resolutionStrategy.force
'com.google.errorprone:error_prone_core:2.3.1' }
+ project.configurations.errorprone { resolutionStrategy.force
'com.google.errorprone:error_prone_core:2.3.4' }
Review comment:
Shouldn't this use `$errorprone_version` too?
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1043,6 +1044,40 @@ class BeamModulePlugin implements Plugin<Project> {
options.errorprone.errorproneArgs.add("-Xep:Slf4jLoggerShouldBeNonStatic:OFF")
options.errorprone.errorproneArgs.add("-Xep:Slf4jFormatShouldBeConst:OFF")
options.errorprone.errorproneArgs.add("-Xep:Slf4jSignOnlyFormat:OFF")
+ options.errorprone.errorproneArgs.add("-Xep:AssignmentToMock:OFF")
Review comment:
Did all of these have violations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
