chamikaramj commented on a change in pull request #14158:
URL: https://github.com/apache/beam/pull/14158#discussion_r589922135
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java
##########
@@ -249,14 +249,33 @@ private boolean isMetricTentative(MetricUpdate
metricUpdate) {
*/
private MetricKey getMetricHashKey(MetricUpdate metricUpdate) {
String fullStepName = metricUpdate.getName().getContext().get("step");
- if (dataflowPipelineJob.transformStepNames == null
- ||
!dataflowPipelineJob.transformStepNames.inverse().containsKey(fullStepName)) {
- // If we can't translate internal step names to user step names, we
just skip them
- // altogether.
- return null;
+
+ if (dataflowPipelineJob.getPipelineProto() != null
Review comment:
Refactored code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
