lazylynx commented on a change in pull request #14137:
URL: https://github.com/apache/beam/pull/14137#discussion_r590394964
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
##########
@@ -750,48 +745,47 @@ def host_from_worker(self):
def start_worker(self):
# type: () -> None
- with SUBPROCESS_LOCK:
- try:
- _LOGGER.info('Attempting to pull image %s', self._container_image)
- subprocess.check_call(['docker', 'pull', self._container_image])
- except Exception:
- _LOGGER.info(
- 'Unable to pull image %s, defaulting to local image if it exists' %
- self._container_image)
- self._container_id = subprocess.check_output([
- 'docker',
- 'run',
- '-d',
- # TODO: credentials
- '--network=host',
- self._container_image,
- '--id=%s' % self.worker_id,
- '--logging_endpoint=%s' % self.logging_api_service_descriptor().url,
- '--control_endpoint=%s' % self.control_address,
- '--artifact_endpoint=%s' % self.control_address,
- '--provision_endpoint=%s' % self.control_address,
+ try:
+ _LOGGER.info('Attempting to pull image %s', self._container_image)
+ subprocess.check_call(['docker', 'pull', self._container_image])
Review comment:
Sorry, I overlooked. Reverted changes concerning this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
