yirutang commented on pull request #11767: URL: https://github.com/apache/beam/pull/11767#issuecomment-794572146
Yes, I will probe in api-discuss to see if there is a better way for this. Other than that, I guess just emphasize it in documentation.... On Tue, Mar 9, 2021 at 2:15 PM reuvenlax <[email protected]> wrote: > @yirutang <https://github.com/yirutang> Understood, but it does lead to a > very error-prone API, since most users will naively assume that success > means success (especially those using Java futures, as this will result in > a successful future). What's worse, these errors will lead to data loss as > users ignore failed commits. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/11767#issuecomment-794527100>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHGYVESCRJKYCAJONONJJVTTC2FVVANCNFSM4NGLIHRQ> > . > -- Thanks. Yiru ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
