robertwb commented on a change in pull request #14179:
URL: https://github.com/apache/beam/pull/14179#discussion_r591126794
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -394,7 +395,7 @@ def _check_for_unsupported_fnapi_features(self,
pipeline_proto):
if (windowing_strategy.merge_status ==
beam_runner_api_pb2.MergeStatus.NEEDS_MERGE and
windowing_strategy.window_fn.urn not in (
- common_urns.session_windows.urn, )):
+ common_urns.session_windows.urn, python_urns.PICKLED_WINDOWFN)):
Review comment:
We also want to accept cross language. Just remove this clause.
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -394,7 +395,7 @@ def _check_for_unsupported_fnapi_features(self,
pipeline_proto):
if (windowing_strategy.merge_status ==
beam_runner_api_pb2.MergeStatus.NEEDS_MERGE and
windowing_strategy.window_fn.urn not in (
- common_urns.session_windows.urn, )):
+ common_urns.session_windows.urn, python_urns.PICKLED_WINDOWFN)):
raise RuntimeError(
'Unsupported merging windowing strategy: %s' %
windowing_strategy.window_fn.urn)
Review comment:
Don't we want to delete the clause below as well (and let the service
reject it)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
