TheNeuralBit commented on a change in pull request #14135:
URL: https://github.com/apache/beam/pull/14135#discussion_r591707315
##########
File path: sdks/python/apache_beam/dataframe/expressions.py
##########
@@ -245,7 +285,7 @@ def requires_partition_by(self):
return partitionings.Nothing()
def preserves_partition_by(self):
- return partitionings.Nothing()
+ return partitionings.Index()
Review comment:
Yeah my motivation here was just that `preserves=Nothing()` is
potentially confusing. In retrospect maybe it's not much of a concern since
`PartitioningSession` should catch incorrect specifications. Regardless - I
like your idea (in the next comment) to solve this with naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
