shehzaadn-vd commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r591894570
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -85,24 +87,34 @@ dependencies {
compile google_api_services_dataflow
compile library.java.avro
compile library.java.google_api_client
+ permitUnusedDeclared library.java.google_api_client // BEAM-11761
+ compile library.java.google_auth_library_credentials
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
+ compile library.java.proto_google_common_protos
shadow library.java.vendored_guava_26_0_jre
compile library.java.slf4j_api
+ compile "io.opencensus:opencensus-api:0.28.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:2.5.1"
+ compile "com.google.guava:guava:25.1-jre"
compile "javax.servlet:javax.servlet-api:3.1.0"
// Conscrypt shouldn't be included here because Conscrypt won't work when
being shaded.
// (Context: https://github.com/apache/beam/pull/13846)
// Conscrypt will be added to runtime dependencies by GrpcVendoring so
compileOnly works for now.
compileOnly "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64" //
BEAM-11761
Review comment:
Actually my second question got answered. There is no linux-x86_64
version of the openjdk-uber jar. See
https://repo.maven.apache.org/maven2/org/conscrypt/conscrypt-openjdk-uber/2.5.1/
@veblush I would guess the linux-x86_64 version was chosen because all jars
under
https://repo.maven.apache.org/maven2/org/conscrypt/conscrypt-openjdk/2.5.1/ are
OS specific and we had to just pick one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
