y1chi commented on a change in pull request #14182:
URL: https://github.com/apache/beam/pull/14182#discussion_r591934742
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMergingFnRunner.java
##########
@@ -151,10 +151,12 @@ public void merge(Collection<W> toBeMerged, W
mergeResult) throws Exception {
KV<T, Iterable<W>> windowsToMerge) throws Exception {
currentWindows = Sets.newHashSet(windowsToMerge.getValue());
windowFn.mergeWindows((MergeContext) mergeContext);
Review comment:
You are right. Theoretically we don't have to store the state and wait
for next merge window invocation to clean up, I don't have strong opinion on
this, I guess only storing last merge results won't take too much memory space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
