ibzib commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r591936571
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -86,24 +86,32 @@ dependencies {
compile google_api_services_dataflow
compile library.java.avro
compile library.java.google_api_client
+ permitUnusedDeclared library.java.google_api_client // BEAM-11761
+ compile library.java.google_auth_library_credentials
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
+ compile library.java.proto_google_common_protos
shadow library.java.vendored_guava_26_0_jre
Review comment:
Vendored and unvendored guava are separate dependencies, so we need one
line for each.
Really, though, this package should not be using unvendored guava at all. We
have a checkstyle rule
[ForbidNonVendoredGuava](https://github.com/apache/beam/blob/42826cd6506f3929c97ac05cab82cc6b1edd039a/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml#L116),
but it looks like checkstyle is
[disabled](https://github.com/apache/beam/blob/42826cd6506f3929c97ac05cab82cc6b1edd039a/runners/google-cloud-dataflow-java/worker/build.gradle#L123)
for this package, which is why violations were allowed (BEAM-5657).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
