robertwb commented on a change in pull request #14178:
URL: https://github.com/apache/beam/pull/14178#discussion_r592109302
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -573,6 +573,7 @@ def axes(self):
all = frame_base._agg_method('all')
any = frame_base._agg_method('any')
+ count = frame_base._agg_method('count')
Review comment:
Count is not associative--wouldn't we want to count per partition, then
sum over all partitions? (Do the tests not catch this, possibly due to being
small, well-partitioned examples?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
