yifanmai commented on a change in pull request #14193:
URL: https://github.com/apache/beam/pull/14193#discussion_r592616137
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -494,11 +494,7 @@ def run_pipeline(self, pipeline, options):
if pre_optimize == 'none' or pre_optimize == 'default':
phases = []
elif pre_optimize == 'all':
- phases = [
- # TODO(BEAM-11694): Enable translations.pack_combiners
- # translations.pack_combiners,
- translations.sort_stages
- ]
+ phases = [translations.pack_combiners, translations.sort_stages]
Review comment:
Is it safe to enable combiner packing for Dataflow now, or do we need to
wait for Dataflow's backend to support CombinePerKeys without subtransforms
first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
