TheNeuralBit commented on pull request #14174:
URL: https://github.com/apache/beam/pull/14174#issuecomment-799763220


   Sorry for not getting back sooner. PTransform has implementations for the 
operators: 
:https://github.com/apache/beam/blob/2306bd0733711f8c7807d059256f9c5b0432f5f7/sdks/python/apache_beam/transforms/ptransform.py#L539
   
   It just passes "pvalueish" directly to the PTransform's `expand` 
implementation. I don't think it pulls apart tuples or dicts, they're just 
passed through directly, so you'll need to handle them as CoGroupByKey does: 
https://github.com/apache/beam/blob/2306bd0733711f8c7807d059256f9c5b0432f5f7/sdks/python/apache_beam/transforms/util.py#L190-L202
   
   It would be worth generalizing this somehow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to