aromanenko-dev commented on a change in pull request #14227:
URL: https://github.com/apache/beam/pull/14227#discussion_r595370759
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -1054,6 +1054,7 @@ public static Sink sink(Schema schema) {
return new AutoValue_ParquetIO_Sink.Builder()
.setJsonSchema(schema.toString())
.setCompressionCodec(CompressionCodecName.SNAPPY)
+ .setRowGroupSize(0)
Review comment:
Yes, I just asked about this because imho `0` looks like as a `magic
number` here which makes it a bit confusing to understand why it's set to 0
without digging into follow-up code.
I think it would be more evident to set it to
`ParquetWriter.DEFAULT_BLOCK_SIZE` by default and avoid additional `if
(getRowGroupSize() > 0)` later. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
