suztomo commented on a change in pull request #14257:
URL: https://github.com/apache/beam/pull/14257#discussion_r595499554
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -113,9 +114,11 @@ class GrpcVendoring_1_36_0 {
"com.google.longrunning",
"com.google.rpc",
"com.google.type",
+ "com.google.geo.type",
Review comment:
This a new package in proto-google-common-protos-2.0.1
```
suztomo-macbookpro44% jar tf
~/Downloads/proto-google-common-protos-2.0.1.jar|grep com/google/geo
com/google/geo/
com/google/geo/type/
com/google/geo/type/ViewportProto.class
com/google/geo/type/ViewportOrBuilder.class
com/google/geo/type/Viewport$Builder.class
com/google/geo/type/Viewport.class
com/google/geo/type/Viewport$1.class
suztomo-macbookpro44% jar tf
~/Downloads/proto-google-common-protos-1.12.0.jar|grep com/google/geo
suztomo-macbookpro44%
```
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -113,9 +114,11 @@ class GrpcVendoring_1_36_0 {
"com.google.longrunning",
"com.google.rpc",
"com.google.type",
+ "com.google.geo.type",
"io.grpc",
"io.netty",
"io.opencensus",
+ "io.perfmark",
Review comment:
gRPC 1.36.0 still uses perfmark. (1.26.0 has it already
https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy#L141
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
