kennknowles commented on a change in pull request #14060:
URL: https://github.com/apache/beam/pull/14060#discussion_r595686327
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2364,6 +2364,22 @@ def from_runner_api_parameter(
def runner_api_requires_keyed_input(self):
return True
+ def get_windowing(self, inputs):
+ # Circular dep, because trigger pulls in CombineFn
+ from apache_beam.transforms.trigger import AfterProcessingTime
Review comment:
Wow, I really must have written this in a hurry. Of course you are
right. In Java every trigger has a continuation trigger and it is evaluated by
a visitor:
https://github.com/apache/beam/blob/4ff08fea21fb79200cd47d1e887b24568a644f7c/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Trigger.java#L103
Gonna convert this back to a draft and do it right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
