kennknowles commented on a change in pull request #14226:
URL: https://github.com/apache/beam/pull/14226#discussion_r596444206
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
##########
@@ -263,8 +263,8 @@ private AsList() {}
// TODO(BEAM-10097): Make this the default expansion for all portable
runners.
if (hasExperiment(input.getPipeline().getOptions(), "beam_fn_api")
- && (hasExperiment(input.getPipeline().getOptions(), "use_runner_v2")
- || hasExperiment(input.getPipeline().getOptions(),
"use_unified_worker"))) {
+ || hasExperiment(input.getPipeline().getOptions(), "use_runner_v2")
Review comment:
That's a good idea. Done here.
I plan to follow up with removing the Fn API overrides in the
DataflowRunner, since the v1beta3 graph is no longer used with Fn API. Then we
may also be able to eliminate the flags there. I did not add it to this PR
since it can be done separately, to prevent scope increase for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]