dpcollins-google commented on a change in pull request #14254:
URL: https://github.com/apache/beam/pull/14254#discussion_r596880207
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java
##########
@@ -229,24 +226,19 @@ public Duration getAllowedTimestampSkew() {
public void processElement(
@Element Row row, @Timestamp Instant t, BoundedWindow w,
OutputReceiver<Row> r)
throws InterruptedException {
- final Future<Value> valueFuture;
-
- if (row.equals(previousRow)) {
- valueFuture = previousFuture;
- } else {
- Map<String, Value> columns = new HashMap<>();
- for (int i : referencedColumns) {
- columns.put(
- columnName(i),
- ZetaSqlBeamTranslationUtils.toZetaSqlValue(
- row.getBaseValue(i, Object.class),
inputSchema.getField(i).getType()));
- }
-
- valueFuture = stream.execute(columns, nullParams);
+ Map<String, Value> columns = new HashMap<>();
+ for (int i : checkArgumentNotNull(referencedColumns)) {
+ columns.put(
+ columnName(i),
+ ZetaSqlBeamTranslationUtils.toZetaSqlValue(
+ row.getBaseValue(i, Object.class),
+ inputSchema.getField(i).getType()));
}
- previousRow = row;
- @Nullable Queue<TimestampedFuture> pendingWindow = pending.get(w);
+ @NonNull
+ Future<Value> valueFuture =
checkArgumentNotNull(stream).execute(columns, nullParams);
+
+ @Nullable Queue<TimestampedFuture> pendingWindow =
checkArgumentNotNull(pending).get(w);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
