apilloud commented on a change in pull request #14241:
URL: https://github.com/apache/beam/pull/14241#discussion_r597298103
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,28 +174,39 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
+ case DOUBLE:
case BOOLEAN:
- case CHAR:
- case BINARY:
+ case VARCHAR:
Review comment:
I was under the impression that null string should be treated as `NULL`,
but I might be wrong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
