BenWhitehead commented on a change in pull request #14261: URL: https://github.com/apache/beam/pull/14261#discussion_r597910244
########## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreIOOptions.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.firestore; + +import com.google.cloud.firestore.FirestoreOptions; +import org.apache.beam.sdk.options.Description; +import org.apache.beam.sdk.options.PipelineOptions; +import org.checkerframework.checker.nullness.qual.Nullable; + +@Description("Options used to configure Cloud Firestore IO") +public interface FirestoreIOOptions extends PipelineOptions { + + /** + * A host port pair to allow connecting to a Cloud Firestore emulator instead of the live service. + * The value passed to this method will take precedent if the {@code FIRESTORE_EMULATOR_HOST} + * environment variable is also set. + * + * @return the string representation of a host and port pair to be used when constructing Cloud + * Firestore clients. + * @see FirestoreOptions.Builder#setEmulatorHost(java.lang.String) + */ + @Nullable + String getEmulatorHostPort(); + + /** + * Define a host port pair to allow connecting to a Cloud Firestore emulator instead of the live + * service. The value passed to this method will take precedent if the {@code + * FIRESTORE_EMULATOR_HOST} environment variable is also set. + * + * @param hostPort the emulator host and port to connect to + * @see FirestoreOptions.Builder#setEmulatorHost(java.lang.String) + */ + void setEmulatorHostPort(String hostPort); Review comment: Sure, I'll update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
