youngoli commented on a change in pull request #14285:
URL: https://github.com/apache/beam/pull/14285#discussion_r599278206
##########
File path: sdks/go/pkg/beam/util/shimx/generate_test.go
##########
@@ -76,7 +76,7 @@ func TestTop_ProcessImports(t *testing.T) {
{name: "shim", got: &Top{Shims: []Func{{Name: "emit"}}}, want:
[]string{ReflectxImport, "context", "keepit", "fmt", "io", "unrelated"}},
{name: "iter&emit", got: &Top{Emitters: []Emitter{{Name:
"emit"}}, Inputs: []Input{{Name: "iter"}}}, want: []string{ExecImport,
TypexImport, "keepit", "unrelated"}},
{name: "functions", got: &Top{Functions: []string{"func1"}},
want: []string{RuntimeImport, "context", "keepit", "fmt", "io", "unrelated"}},
- {name: "types", got: &Top{Types: []string{"func1"}}, want:
[]string{RuntimeImport, "context", "keepit", "fmt", "io", "unrelated"}},
+ {name: "types", got: &Top{Types: []string{"func1"}}, want:
[]string{SchemaImport, RuntimeImport, "context", "keepit", "fmt", "io",
"unrelated"}},
Review comment:
A test with a type prefixed with `"beam."` could be good to test that
behavior works. Same as this test, but it could say `beam.func1` and would
expect `SchemaImport` to not be present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
