kennknowles commented on pull request #14313: URL: https://github.com/apache/beam/pull/14313#issuecomment-805215355
Yes, that is exactly the difference. NeedsRunner is really a hack to break the dependency cycle. We could even rename it to `CoreSdkTestToRunOnDirectRunner` so we don't have to document (people won't find documentation anyhow). We can make a stronger statement about ValidatesRunner IMO: the `ValidatesRunner` tests should be the definition of a correct runner. Of course the runner also calls back into the SDK so it does test both, but mostly the runner. We should ensure that the SDK and tests are correct by using the ULR so that we know that any failure in these tests on other runners indicates a limitation of the runner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
