tvalentyn commented on a change in pull request #14292:
URL: https://github.com/apache/beam/pull/14292#discussion_r600823746
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_avro_tools_test.py
##########
@@ -90,9 +86,7 @@ def test_convert_bigquery_schema_to_avro_schema(self):
# Test that schema can be parsed correctly by avro
parsed_schema = Parse(json.dumps(avro_schema))
- # Avro RecordSchema provides field_map in py3 and fields_dict in py2
- field_map = getattr(parsed_schema, "field_map", None) or \
- getattr(parsed_schema, "fields_dict", None)
+ field_map = getattr(parsed_schema, "field_map", None)
Review comment:
We can eliminate this variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
