apilloud commented on a change in pull request #14332:
URL: https://github.com/apache/beam/pull/14332#discussion_r600973232
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -163,6 +164,15 @@
+ " The date_part includes: "
+ INTERVAL_DATE_PART_MSG;
+ // Maximum and minimum allowed values for the NUMERIC/DECIMAL data type.
+ //
https://github.com/google/zetasql/blob/master/docs/data-types.md#decimal-type
+ private static final BigDecimal MAX_NUMERIC_VALUE =
Review comment:
That class is in the test package because it is only used by tests. If
it would be useful, you can move it out.
See: https://github.com/apache/beam/pull/12174#discussion_r454618830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
