robinyqiu commented on a change in pull request #14342:
URL: https://github.com/apache/beam/pull/14342#discussion_r601922382
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamUnnestRule.java
##########
@@ -109,7 +109,7 @@ public void onMatch(RelOptRuleCall call) {
new BeamUnnestRel(
correlate.getCluster(),
correlate.getTraitSet().replace(BeamLogicalConvention.INSTANCE),
- outer,
+ convert(outer,
outer.getTraitSet().replace(BeamLogicalConvention.INSTANCE)),
Review comment:
The bug is here! This code forgot to call `convert` on its input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
