aromanenko-dev commented on a change in pull request #14338:
URL: https://github.com/apache/beam/pull/14338#discussion_r602433737
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -903,6 +903,8 @@ public void processElement(ProcessContext context) throws
Exception {
if (connection == null) {
connection = dataSource.getConnection();
}
+ // PostgreSQL requires autocommit to be disabled to enable cursor
streaming
Review comment:
Well, I guess it won't be so easy to check without additional work
(please, correct me if I'm wrong).
My main concern is the following - if we provide a way to configure IO in
some way, we don't have to silently override it without taking into account the
user config options if they were set explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
