tvalentyn commented on a change in pull request #14343:
URL: https://github.com/apache/beam/pull/14343#discussion_r603594360
##########
File path: sdks/java/container/boot.go
##########
@@ -97,7 +97,12 @@ func main() {
// (2) Retrieve the staged user jars. We ignore any disk limit,
// because the staged jars are mandatory.
- dir := filepath.Join(*semiPersistDir, "staged")
+ // Using the SDK Harness ID in the artifact destination path to make
sure that dependencies used by multiple
+ // SDK Harnesses in the same VM do not conflict. This is needed since
some runners (for example, Dataflow)
+ // may share the artifact staging directory across multiple SDK
Harnesses
+ // TODO(BEAM-9455): consider removing the SDK Harness ID from the
staging path after Dataflow can properly
+ // seperate out dependencies per environment.
+ dir := filepath.Join(*semiPersistDir, *id, "staged")
Review comment:
Is this directory just a temp directory used by the boot laucher, or the
launcher will expect some content in that directory provisioned by the runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
