emilssolmanis commented on a change in pull request #14272:
URL: https://github.com/apache/beam/pull/14272#discussion_r604038008
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java
##########
@@ -107,7 +107,7 @@
private final PipelineOptions options;
- private static class PipelineRunEnforcement {
+ protected static class PipelineRunEnforcement {
Review comment:
They can be, it could be argued that `protected` allows for some
extensibility, i.e., if they were protected to begin with, I could have added a
subclass implementing the 2 JUnit5 interfaces somewhere in our own test code
instead of making a whole Beam PR.
I don't know if there's an **actual** use case mind you, I'm unfamiliar with
TestNG and other test frameworks and whether there's any need, so perfectly
happy to make them package-private to hide from clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
