kennknowles commented on a change in pull request #14374:
URL: https://github.com/apache/beam/pull/14374#discussion_r604464516



##########
File path: sdks/python/apache_beam/dataframe/io_test.py
##########
@@ -56,12 +63,14 @@ def temp_dir(self, files=None):
           fout.write(contents)
     return dir + os.path.sep
 
-  def read_all_lines(self, pattern):
+  def read_all_lines(self, pattern, delete=False):
     for path in glob.glob(pattern):
       with open(path) as fin:
         # TODO(Py3): yield from
         for line in fin:
           yield line.rstrip('\n')
+      if delete:

Review comment:
       https://docs.pytest.org/en/stable/tmpdir.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to