Amar3tto commented on pull request #14354:
URL: https://github.com/apache/beam/pull/14354#issuecomment-813353953
> Thanks this looks good at first glance. Could you add some test-cases for
edge cases, e.g. I'm curious if we handle:
>
> ```
> Row[] transactions {
> String[] banks,
> Double purchaseAmount
> }
> ->
> String[][] transactions_banks,
> Double[] transactions_purchaseAmount
> ```
>
> and:
>
> ```
> Row[] transactions {
> Row[] banks {
> String name
> String address
> },
> Double purchaseAmount
> }
> ->
> String[][] transactions_banks_name,
> String[][] transactions_banks_address,
> Double[] transactions_purchaseAmount
> ```
Done, handled both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
