mouyang commented on pull request #14350:
URL: https://github.com/apache/beam/pull/14350#issuecomment-813437945


   @TheNeuralBit honestly after seeing that, I don't know without additional 
context.  It's clear now that BigQueryUtils and BigqueryClient duplicates some 
efforts.  Removing the type conversions in BigqueryClient would be closer to 
the metal and consistent with the second approach you proposed earlier.  There 
also no performance hit as previously feared in staying with Strings because 
everything starts off as a String.
   
   I'm fine with waiting to hear back from @pabloem but the second option you 
proposed still looks viable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to