kennknowles commented on a change in pull request #14322:
URL: https://github.com/apache/beam/pull/14322#discussion_r608936771
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
##########
@@ -596,4 +598,138 @@ public void countAssertsMultipleCallsIndependent() {
assertThat(PAssert.countAsserts(pipeline), equalTo(3));
}
+
+ @Test
+ public void testPAssertThatFlattened() {
Review comment:
I see you added `ValidatesRunner` not `NeedsRunner`. This is actually
OK. PAssert is not a primitive transform, so it does not fit the category. But
a few runners do treat it special so it is good to include.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
