kennknowles commented on a change in pull request #14473:
URL: https://github.com/apache/beam/pull/14473#discussion_r609930492
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/PCollectionConsumerRegistry.java
##########
@@ -213,38 +211,39 @@ public MetricTrackingFnDataReceiver(
this.pTransformId = consumerAndMetadata.getPTransformId();
HashMap<String, String> labels = new HashMap<String, String>();
labels.put(Labels.PCOLLECTION, pCollectionId);
+
+ // Collect the metric in a metric container which is not bound to the
step name.
+ // This is required to count elements from impulse steps, which will
produce elements outside
Review comment:
I appreciate the detailed comment, but I still don't actually understand
what it means :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
