scwhittle commented on pull request #14480: URL: https://github.com/apache/beam/pull/14480#issuecomment-816118141
R: @amaliujia @kennknowles This could go in instead of https://github.com/apache/beam/pull/14458 or after it. Just wanted to get some eyes on it earlier The new InboundDataClient method runWhenComplete doesn't seem the cleanest to me but seems like it would work. Alternatively we could change that interface to expose a CompletableFuture itself since all the implementations seem to use that. That could avoid the proliferation of awaitWhenComplete, runWhenComplete that mirror the CompletableFuture methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
