scwhittle commented on a change in pull request #14498:
URL: https://github.com/apache/beam/pull/14498#discussion_r610815450
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsEnvironment.java
##########
@@ -52,8 +53,8 @@
private static final AtomicBoolean METRICS_SUPPORTED = new
AtomicBoolean(false);
private static final AtomicBoolean REPORTED_MISSING_CONTAINER = new
AtomicBoolean(false);
- private static final ThreadLocal<@Nullable MetricsContainer>
CONTAINER_FOR_THREAD =
- new ThreadLocal<>();
+ private static final ThreadLocal<@Nullable MetricsContainerHolder>
CONTAINER_FOR_THREAD =
Review comment:
Yes due to the withInitialValue, however I believe I tried it and it
didn't seem to work without the Nullable. I think it didn't like it later with
the get method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
