chamikaramj commented on a change in pull request #14500:
URL: https://github.com/apache/beam/pull/14500#discussion_r610983164
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -191,6 +193,10 @@ private String getApplicationName(AppliedPTransform<?, ?,
?> appliedPTransform)
if (name.isEmpty()) {
name = "unnamed-ptransform";
}
+ // Normalize, trim, and uniqify.
+ int maxNameLength = 100;
+ name = Normalizer.normalize(name, Form.NFC).replaceAll("[^A-Za-z0-9-_]",
"-");
Review comment:
Added a comment to the proto recommending alphanumeric characters, '_',
and '-' for transform IDs.
Also added a test.
Corresponding Python changes are in
https://github.com/apache/beam/pull/14502.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
