nehsyc commented on a change in pull request #14499:
URL: https://github.com/apache/beam/pull/14499#discussion_r611001573
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1417,7 +1417,12 @@ def _add_random_shard(element):
value = element[1]
return ((key, random.randint(0, DEFAULT_SHARDS_PER_DESTINATION)), value)
- def _to_hashable_table_ref(table_ref_elem_kv):
+ V = TypeVar('V')
+ TABLE_REF_TYPE = TypeVar('TABLE_REF_TYPE')
Review comment:
Aha. That makes more sense! Corrected.
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1417,7 +1417,12 @@ def _add_random_shard(element):
value = element[1]
return ((key, random.randint(0, DEFAULT_SHARDS_PER_DESTINATION)), value)
- def _to_hashable_table_ref(table_ref_elem_kv):
+ V = TypeVar('V')
+ TABLE_REF_TYPE = TypeVar('TABLE_REF_TYPE')
+
+ def _to_hashable_table_ref(
Review comment:
Good idea. I moved it to bigquery_tools.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
