nehsyc commented on a change in pull request #14499:
URL: https://github.com/apache/beam/pull/14499#discussion_r611098461
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -69,6 +71,11 @@
except ImportError:
pass
+try:
Review comment:
I had to explicitly import this otherwise many tests failed with
"apache_beam.io.gcp.internal.clients.bigquery has no attribute TableReference"
- I guess bigquery lib was not available in some environments. The pylint check
also failed possibly because of this but I haven't figured out what's wrong.
Any insights?
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -69,6 +71,11 @@
except ImportError:
pass
+try:
Review comment:
I had to explicitly import this otherwise many tests failed with
"apache_beam.io.gcp.internal.clients.bigquery has no attribute TableReference"
- I guess bigquery lib was not available in some environments. The pylint check
also failed possibly because of this but I haven't figured out what's wrong.
Any insights?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
