robertwb commented on a change in pull request #14455:
URL: https://github.com/apache/beam/pull/14455#discussion_r612038793
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -418,6 +422,12 @@ def encode_to_stream(self, value, stream, nested):
self.fallback_coder_impl.encode_to_stream(value, stream, nested)
def encode_special_deterministic(self, value, stream):
+ if not self.warn_deterministic_fallback:
+ _LOGGER.warning(
+ "Using fallback deterministic coder for type '%s' in '%s'. ",
+ type(value),
+ self.requires_deterministic_step_label)
+ self.warn_deterministic_fallback = True
Review comment:
Nit: A True value sounds like it will warn, which is opposite of the
semantic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
