scwhittle commented on pull request #14480: URL: https://github.com/apache/beam/pull/14480#issuecomment-818649516
Don't merge this yet, I see an issue. I was using add() in completeInbound and not looking at return value. I think that could end up with a deadlock as the POISON would not get added to the queue. I'm going to try to improve the unit tests to catch that and fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
