iemejia commented on a change in pull request #14520:
URL: https://github.com/apache/beam/pull/14520#discussion_r612488480
##########
File path:
runners/spark/2/src/main/java/org/apache/beam/runners/spark/structuredstreaming/SparkStructuredStreamingRunner.java
##########
@@ -111,22 +109,8 @@ public static SparkStructuredStreamingRunner create(
* @return A pipeline runner that will execute with specified options.
*/
public static SparkStructuredStreamingRunner fromOptions(PipelineOptions
options) {
- SparkStructuredStreamingPipelineOptions sparkOptions =
Review comment:
We were executing this relatively heavy step twice because we were doing
it in `fromOptions` and in each Spark runner `.run()` method so I removed it
from here and it is now up to the runner to take care of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]