kennknowles commented on pull request #14504:
URL: https://github.com/apache/beam/pull/14504#issuecomment-819098367


   > Seems like in this PR template dataflow python postcommits are attributed 
to Flink and there is one extra empty column at the end
   
   Fixed. May as well browse the authoritative one at 
https://github.com/apache/beam/blob/9cf2451f5831831268297e50fa24234c09f2a6f3/.github/PULL_REQUEST_TEMPLATE.md
   
   > > Jenkins jobs where the same job is expected to give status for a number 
of these cells.
   > Could you give an example to understand what you mean?
   
   The "Go PostCommit" I believe has "ValidatesRunner tests" as well as 
"Examples on Dataflow" tests, etc. Java postcommit used to have "Examples on 
Dataflow" and "IO integration tests on DirectRunner", etc. 
   
   Thinking about the hierarchy of testing job > suite > class > method, the 
job is actually usually an implementation detail,  though the ability to 
configure them makes them able to give contradictory results for the same 
suite. The suite is probably the signal we want. They aren't perfectly aligned. 
I am just fixing up the PR template to reflect what we already have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to