apilloud commented on a change in pull request #14476:
URL: https://github.com/apache/beam/pull/14476#discussion_r612815582
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java
##########
@@ -122,7 +122,7 @@ public RelNode convert(RelNode rel) {
* Returns true only if the literal can be correctly implemented by {@link
* org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel} in ZetaSQL.
*/
- private static boolean udfSupportsLiteralType(RelDataType type) {
+ static boolean udfSupportsLiteralType(RelDataType type) {
Review comment:
It appears `BeamJavaUdfCalcRule`/`BeamZetaSqlCalcRule` are out of sync
with their respective `CalcRelSplitter.RelType`. The logic is mostly duplicated
between the two, but it is slightly different. Can you make a abstract rule
that takes a single `CalcRelSplitter.RelType` and replace the old CalcRules
with that? (Possibly make a fake `CalcRelSplitter.RelType` that always returns
false then use the CalcSplitter?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
