kennknowles commented on pull request #14540:
URL: https://github.com/apache/beam/pull/14540#issuecomment-819808989
Confirmed that there are no uses outside `WindowFn`
```
beam % grep -r 'getOutputTime(' *
model/pipeline/build/generated/source/proto/main/java/org/apache/beam/model/pipeline/v1/RunnerApi.java:
org.apache.beam.model.pipeline.v1.RunnerApi.OutputTime.Enum getOutputTime();
model/pipeline/build/generated/source/proto/main/java/org/apache/beam/model/pipeline/v1/RunnerApi.java:
@java.lang.Override public
org.apache.beam.model.pipeline.v1.RunnerApi.OutputTime.Enum getOutputTime() {
model/pipeline/build/generated/source/proto/main/java/org/apache/beam/model/pipeline/v1/RunnerApi.java:
public org.apache.beam.model.pipeline.v1.RunnerApi.OutputTime.Enum
getOutputTime() {
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java:
TimestampCombiner timestampCombiner =
timestampCombinerFromProto(proto.getOutputTime());
grep: warning:
sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go: recursive
directory loop
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/WindowFn.java:
* then {@code getOutputTime(A, window) <= getOutputTime(B, window)}.
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/WindowFn.java:
public Instant getOutputTime(Instant inputTimestamp, W window) {
grep: warning:
sdks/java/container/.gogradle/project_gopath/src/github.com/apache/beam/sdks/java/boot:
recursive directory loop
```
The matches in the generated proto code are actually the proto name for
`TimestampCombiner` so they are false matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
